Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout@v1 breaking change - overwrites ~/.gitconfig #60

Closed
rectalogic opened this issue Oct 28, 2019 · 5 comments
Closed

checkout@v1 breaking change - overwrites ~/.gitconfig #60

rectalogic opened this issue Oct 28, 2019 · 5 comments

Comments

@rectalogic
Copy link

As per issue #14, the standard way to make private submodules work with checkout is to use insteadOf to rewrite git@ urls to https:// and to use a private access token, e.g.:

    - name: Fix submodules
      run: echo -e '[url "https://github.com/"]\n  insteadOf = "git@github.com:"' >> ~/.gitconfig
    - name: Checkout server
      uses: actions/checkout@v1
      with:
        fetch-depth: 1
        submodules: true
        token: ${{ secrets.CUREATR_PAT }}

As of a few days ago, checkout@v1 now seems to overwrite ~/.gitconfig and this no longer works.
It appears this PR made the change #56

How should we make private submodules work with the non-backward compatible checkout@v1?
Also where is the source code to the checkout plugin, it would be useful for debugging breaking changes like this.

@tuler
Copy link

tuler commented Oct 28, 2019

All my builds are broken because of private submodules.
I used to do the git -> https replacements, but now I use relative submodule urls (../), and it was working fine until today. I see the error below:

##[error]fatal: could not read Username for 'https://github.com': terminal prompts disabled

@mdellavo
Copy link

Using previous commit hash will work in the interim.

     - name: Checkout
       uses: actions/checkout@f6ce2afa7079cb075a124c93c79d61779d845782

@thboop
Copy link
Contributor

thboop commented Oct 28, 2019

@rectalogic, @tuler ,
Thanks for the report this bug has been addressed. uses: checkout/actions@v1 has been fixed to work as it did previously. Please try updating your workflows to the v1 tag and let me know if you see any more issues.

Also where is the source code to the checkout plugin, it would be useful for debugging breaking changes like this.

We are working on this as well!

@tuler
Copy link

tuler commented Oct 28, 2019

It's working!

@ethomson
Copy link
Contributor

Thanks for reporting this, @rectalogic and @tuler. And thanks for the prompt fix, @thboop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants