Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Bump Needed in actions/core #380

Closed
oliveirafilipe opened this issue Nov 4, 2020 · 3 comments
Closed

Possible Bump Needed in actions/core #380

oliveirafilipe opened this issue Nov 4, 2020 · 3 comments

Comments

@oliveirafilipe
Copy link

oliveirafilipe commented Nov 4, 2020

Hi Folks!

As you guys at Github may know, there is a security vulnerability involving add-path and set-env.

The recommended is:

For now, users should upgrade to @actions/core v1.2.6 or later, and replace any instance of the set-env or add-path commands in their workflows with the new Environment File Syntax.

Is there any reason why this action is still using an old version of @actions/core?

"@actions/core": "^1.1.3",

"dependencies": {
"@actions/core": {
"version": "1.1.3",
"resolved": "https://registry.npmjs.org/@actions/core/-/core-1.1.3.tgz",
"integrity": "sha512-2BIib53Jh4Cfm+1XNuZYYGTeRo8yiWEAUMoliMh1qQGMaqTF4VUlhhcsBylTu4qWmUx45DrY0y0XskimAHSqhw=="
},

@oliveirafilipe
Copy link
Author

oliveirafilipe commented Nov 4, 2020

Sorry guys, I didn't see that there is already an PR with this bump: #361

@peaceiris
Copy link

peaceiris commented Nov 15, 2020

Actually, the actions/checkout does not use the core.addPath and core.exportVariable so I do not think this action throws the error message. Maybe, you need to check which action returns the message. See also #383 (comment)

@oliveirafilipe
Copy link
Author

Hi @peaceiris , indeed this action does not use the core.addPath and core.exportVariable. I was just reviewing all the actions in my pipeline and seeing if they already had updated their action/core version since it is a very important patch.

Since there is already an PR with this bump, I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants