Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build because all is no more #264

Merged
merged 1 commit into from May 31, 2020
Merged

build because all is no more #264

merged 1 commit into from May 31, 2020

Conversation

gnawhleinad
Copy link
Contributor

fixes #263.

ericsciple
ericsciple reviewed May 31, 2020
View reviewed changes
__test__/verify-no-unstaged-changes.sh
@@ -12,6 +12,6 @@ if [[ "$(git status --porcelain)" != "" ]]; then
echo ----------------------------------------
echo Troubleshooting
echo ----------------------------------------
echo "::error::Unstaged changes detected. Locally try running: git clean -ffdx && npm ci && npm run all"
echo "::error::Unstaged changes detected. Locally try running: git clean -ffdx && npm ci && npm run build"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs npm format now too:

    echo "::error::Unstaged changes detected. Locally try running: git clean -ffdx && npm ci && npm run format && npm run build"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incrementally better. so i'll go ahead and merge :)

thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also i pushed an update to include npm run format

@ericsciple ericsciple merged commit 65865e1 into actions:master May 31, 2020
kpeterson-sf pushed a commit to sf-bt-neteng/checkout that referenced this pull request Oct 16, 2020
@gnawhleinad @kpeterson-sf
build because all is no more (actions#264)
f18de14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsciple ericsciple ericsciple left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm run all is missing
2 participants
@gnawhleinad @ericsciple