Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout folked branch but pull request's github.event.pull_request.base.sha is synced with origin repo's main branch, not folked repo's main branch. #1621

Closed
AllyW opened this issue Feb 22, 2024 · 1 comment

Comments

@AllyW
Copy link

AllyW commented Feb 22, 2024

I checkout a test-branch from a folked repo of a repo, and then make a pull request to the original repo's main branch.

But pull request's github.event.pull_request.base.sha is shown as original repo's head commit of main branch, not folked repo's head commit of main branch (original main branch's head commit might have changed cause someone may have merged some code into it, so folked repo's main branch is behind the original repo main branch).

Thank you 🙇‍♀ for wanting to create an issue in this repository. Before you do, please ensure you are filing the issue in the right place. Issues should only be opened on if the issue relates to code in this repository.

If your issue is relevant to this repository, please delete this text and continue to create this issue. Thank you in advance.

@cory-miller
Copy link
Contributor

This is working as intended (it also it not related to actions/checkout).

If you open a PR against the original repository, then the "base" is the original repository.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests
https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants