-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running rust-toolchain twice in same workflow can result in unstable errors #12
Comments
Meant to post this over at dtolnay's repository. It's now there as dtolnay/rust-toolchain#73. |
Since I based this on dtolnay's action I was curious about the issue. But I cannot reproduce it. Neither with this action nor with your code snippet. I only get this when running
Do you have a repository and a link to an actions log where this error occurs? |
See dtolnay/rust-toolchain#74. This has now been fixed in that repository. I fixed the above. it should have been |
Not all version support the new sparse protocol. While old versions ignore the value, 1.66 and other fail due to unstable features. If such a version is detected, always downgrade to the git protocol. This fixes running the action twice with different toolchains. Even if the first install uses something which supports "sparse", the second run can still downgrade it to "git". Closes #12
I published a fix for this problem. It ended up quite different from dtolnay/rust-toolchain#74 because that fix is incomplete. |
Example workflow where we use the nightly for formatting, but stable for linting with Clippy:
This results in the following error when trying to run the
clippy
command:The text was updated successfully, but these errors were encountered: