Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aspect ratio #583

Open
carriemorrison opened this issue Feb 3, 2023 · 4 comments
Open

Add aspect ratio #583

carriemorrison opened this issue Feb 3, 2023 · 4 comments
Assignees
@carriemorrison

Comments

@carriemorrison
Copy link
Collaborator

Support is good now: https://caniuse.com/?search=aspect-ratio
@carriemorrison carriemorrison self-assigned this Feb 3, 2023
@redonkulus
Copy link
Contributor

We have support already https://github.com/acss-io/atomizer/blob/main/packages/atomizer/src/rules.js#L306

@carriemorrison
Copy link
Collaborator Author

carriemorrison commented Feb 3, 2023 •
edited

That requires custom? Could be nice if we could supply param to value since images come at constantly different sizes. Similar how width is done so you just supply both image size values Ar(1920/1080)

@redonkulus
Copy link
Contributor

So just switch allowParamToValue to true?

@redonkulus
Copy link
Contributor

Or some variant of calculatePercentage but doesn't convert to %...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carriemorrison carriemorrison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@redonkulus @carriemorrison