feat: support Google Tag Manager and Google Tags via an env variable #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
requested review from
eoinkelly,
lukeify,
halles,
joshmcarthur,
robotdana,
robramsaynz,
JacobBriggsAckama,
brooke-m and
hopkincame
G-Rath
force-pushed
the
support-google-analytics
branch
4 times, most recently
from
80cf99e
to
eeefd6b
Compare
|
At our rails catchup, we discussed a number of aspects relating to this PR:
|
eoinkelly
reviewed
Aug 25, 2023
| j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src= | ||
| 'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); | ||
| })(window,document,'script','dataLayer','<%= google_analytics_id %>');</script> | ||
| <!-- End Google Tag Manager --> |
There was a problem hiding this comment.
I had a quick look at how we implemented this on my most recent client project:
<%= javascript_tag nonce: true, defer: true do -%>
var dataLayer = [];
(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'https://www.googletagmanager.com/gtm.js?id='+i+dl;var n=d.querySelector('[nonce]');
n&&j.setAttribute('nonce',n.nonce||n.getAttribute('nonce'));f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','GTM-XXXXXX');
<% end -%>There are two things I think we should steal from this:
- use
javascript_tag nonce: true, ...to avoid the CSP yelling at us about an embedded<script>without a nonce - Define the
dataLayervariable in JS. GTM does not define this for you.
There was a problem hiding this comment.
🤔 maybe it would be worth linking to https://github.com/google/data-layer-helper in a comment - it's really the best dev focused docs I've found about how to actually use the dataLayer
G-Rath
force-pushed
the
support-google-analytics
branch
from
fcce2a7
to
c30cdad
Compare
JacobBriggsAckama
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the different patterns we've used over the years for supporting this in our apps - in the end I've gone with having a dedicated analytics partial for "head" and "body" to provide a dedicated grouping that'll also hopefully encourage people to think about the situation if they find these files growing significantly.
I'm marking this as a draft until we've decided what wording we want to be in these files for which I'd like input from others.
Resolves #439