Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Google Tag Manager out of the box #439

Open
G-Rath opened this issue Jun 29, 2023 · 4 comments · May be fixed by #455
Open

Support Google Tag Manager out of the box #439

G-Rath opened this issue Jun 29, 2023 · 4 comments · May be fixed by #455
Labels

Comments

@G-Rath
Copy link
Contributor

G-Rath commented Jun 29, 2023

We tend to have to setup at least Google Tag Manager on most of our apps, and while the snippiet is always the same we usually do it slightly differently each time - sometimes we just have it in layouts/application.html.erb, sometimes its in layouts/_google.html.erb, and so on.

It would be good if we could have an established pattern for structuring analytics in views, and had support out of the box for enabling Google Tag Manager by just setting an env variable.

We could also hopefully use this to help encourage good practices around analytics.

@robotdana
Copy link
Contributor

pull from an existing app

@eoinkelly
Copy link
Contributor

Given that analytics are sometimes a contentious topic, I'm hesitant to make it part of every app. I think we should make this a variant that devs opt-in to via the YAML config. That would make the path clear for templating other kinds of analytics too.

@robotdana
Copy link
Contributor

csp needs to be updated to allow google tag manager and its children

@robotdana
Copy link
Contributor

we should keep that as locked down as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants