Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using SVG for default favicon #398

Open
mischa-s opened this issue Nov 2, 2022 · 4 comments
Open

Consider using SVG for default favicon #398

mischa-s opened this issue Nov 2, 2022 · 4 comments

Comments

@mischa-s
Copy link
Contributor

mischa-s commented Nov 2, 2022

Modern browsers now support using SVGs for favicons - should we have a stock favicon which uses https://www.rubydoc.info/github/rails/webpacker/Webpacker/Helper:favicon_pack_tag in the generated template to encourage projects down this path and make it easy?

@robotdana
Copy link
Contributor

we should choose a random emoji https://twitter.com/LeaVerou/status/1241619866475474946

@robotdana
Copy link
Contributor

maybe our approach for predefining a range of icons in the template needs to be further thought about

should the template be defining icons or icons that 404? should we insist on a favicon.ico at root for various tools? (strava apparently does this)

we should probably not supply default generic icons as the various defaults when things are missing are better than explicitly defining something wrong

@robotdana
Copy link
Contributor

maybe we should have comments with todos for here is where your icon goes

@eoinkelly
Copy link
Contributor

eoinkelly commented Sep 22, 2023

Do browsers still cache old icons for ages? I think our advice should include making sure that your icon has a fingerprint in the filename and not to rely on default /favicon.* naming to avoid these issues.

Overall I am not in favour of us adding a default favicon. I am in favour of us maybe adding a helpful comment near where they would add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants