Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-typescript variant failing in CI #323

Closed
eoinkelly opened this issue Aug 3, 2022 · 3 comments
Closed

react-typescript variant failing in CI #323

eoinkelly opened this issue Aug 3, 2022 · 3 comments

Comments

@eoinkelly
Copy link
Contributor

See this re-build of CI on main which used to pass

The relevant output is:

yarn run v1.22.18
$ tsc -p . --noEmit
node_modules/@types/yargs/index.d.ts:28:10 - error TS2305: Module '"yargs-parser"' has no exported member 'DetailedArguments'.

28 import { DetailedArguments, Configuration } from 'yargs-parser';
            ~~~~~~~~~~~~~~~~~

node_modules/@types/yargs/index.d.ts:28:29 - error TS2305: Module '"yargs-parser"' has no exported member 'Configuration'.

28 import { DetailedArguments, Configuration } from 'yargs-parser';
                               ~~~~~~~~~~~~~


Found 2 errors in the same file, starting at: node_modules/@types/yargs/index.d.ts:28

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This issue seems to be strongly correlated to electron-userland/electron-builder#5446 (comment)

@G-Rath
Copy link
Contributor

G-Rath commented Aug 3, 2022

yargs/yargs-parser#452 is the issue to follow

@eoinkelly
Copy link
Contributor Author

yargs/yargs-parser#455 has resolved this now.

@G-Rath
Copy link
Contributor

G-Rath commented Aug 4, 2022

Yeah but the TS variant still seems to be failing for some reason - I'm looking into this looks like it was just that ci re-run being weird 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants