Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with sprockets 4 #10

Closed
mischa-s opened this issue Oct 13, 2019 · 5 comments
Closed

compatibility with sprockets 4 #10

mischa-s opened this issue Oct 13, 2019 · 5 comments

Comments

@mischa-s
Copy link
Contributor

mischa-s commented Oct 13, 2019

A new version of sprockets was recently released which creates the following error

image

The short term fix is to add gem "sprockets", "~> 3.0" to the gem file but a proper fix will need to be implement https://github.com/rails/sprockets/blob/master/UPGRADING.md#guide-to-upgrading-from-sprockets-3x-to-4x

@joshmcarthur
Copy link
Contributor

@mischa-s this doesn't help you in the short term, but I believe sprockets may not be a thing that is required at all if you're happy to stick with the *_pack_tag helpers, since Webpacker takes care of all this without involving sprockets.

@mischa-s
Copy link
Contributor Author

thanks I'll have a look at that

@mischa-s
Copy link
Contributor Author

Also going to leave this here. If it gets merged it will add the option of specifying a custom route for the manifest rails/sprockets-rails#446

@eoinkelly
Copy link
Contributor

Rails 6.0.1 brings in sprockets-rails (>= 2.0.0) as a dependency so we can't really avoid installing it, even if you plan to use webpacker only in the app.

eoinkelly added a commit that referenced this issue Dec 2, 2019
eoinkelly added a commit that referenced this issue Dec 4, 2019
@eoinkelly
Copy link
Contributor

Fixed by PR #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants