Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: convert to typescript and release as ESM-only #28

Merged
merged 3 commits into from
Oct 12, 2022
Merged

feat!: convert to typescript and release as ESM-only #28

merged 3 commits into from
Oct 12, 2022

Conversation

achingbrain
Copy link
Owner

BREAKING CHANGE: this module is now ESM-only

@wemeetagain
Copy link
Contributor

Change lgtm, looks like linter errors:

/home/runner/work/uint8arrays/uint8arrays/src/concat.ts:5:8: Unexpected nullable number value in conditional. Please handle the nullish/zero/NaN cases explicitly. [Error/@typescript-eslint/strict-boolean-expressions]
/home/runner/work/uint8arrays/uint8arrays/src/from-string.ts:13:8: Unexpected object value in conditional. The condition is always true. [Error/@typescript-eslint/strict-boolean-expressions]
[10:37:55] eslint [failed]
/home/runner/work/uint8arrays/uint8arrays/src/from-string.ts:18:33: Invalid type "any" of template literal expression. [Error/@typescript-eslint/restrict-template-expressions]
/home/runner/work/uint8arrays/uint8arrays/src/to-string.ts:13:8: Unexpected object value in conditional. The condition is always true. [Error/@typescript-eslint/strict-boolean-expressions]
[10:37:55] → Lint errors
/home/runner/work/uint8arrays/uint8arrays/test/from-string.spec.ts:9:1: Use "@ts-expect-error" to ensure an error is actually being suppressed. [Error/@typescript-eslint/prefer-ts-expect-error]

@achingbrain
Copy link
Owner Author

Going to make this a draft for now, we should resolve #30 first.

@achingbrain achingbrain marked this pull request as draft August 2, 2022 07:57
@achingbrain
feat!: convert to typescript and release as ESM-only
02b8756 
Updates multiformats to ESM-only so since this module can no longer
be used from CJS code, convert this module to typescript and publish
as ESM-only as well.

BREAKING CHANGE: this module is now ESM-only
@achingbrain achingbrain changed the title feat: convert to typescript feat!: convert to typescript Oct 12, 2022
@achingbrain achingbrain marked this pull request as ready for review October 12, 2022 10:53
@achingbrain achingbrain changed the title feat!: convert to typescript feat!: convert to typescript and release as ESM-only Oct 12, 2022
@achingbrain achingbrain merged commit e4c9627 into master Oct 12, 2022
@achingbrain achingbrain deleted the feat/convert-to-typescript branch October 12, 2022 10:59
github-actions bot pushed a commit that referenced this pull request Oct 12, 2022
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
93b959b 
## [4.0.0](v3.1.1...v4.0.0) (2022-10-12)

### ⚠ BREAKING CHANGES

* this module is now ESM-only

### Features

* convert to typescript and release as ESM-only ([#28](#28)) ([e4c9627](e4c9627))

### Documentation

* fix readme header ([803cb5f](803cb5f))
@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@achingbrain @wemeetagain