Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sticky toc #44

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Sticky toc #44

wants to merge 8 commits into from

Conversation

carolinemao
Copy link
Collaborator

@carolinemao carolinemao commented Jun 2, 2022 •
edited

pages with table of contents now have them as fixed sidebars :-)

TODO

  • mobile-friendly
  • adjust padding for h3, h4 etc
  • decrease indent for h3, h4 etc
  • fix overflowing long sidebars

@carolinemao carolinemao linked an issue Jun 2, 2022 that may be closed by this pull request
Make table of contents on long pages sticky #39
Open
3 tasks
ryanrosenberg
ryanrosenberg reviewed Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@ryanrosenberg ryanrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! It looks good and is a nice QOL improvement. One thing to fix: on pages with long TOCs (e.g. hosting guidelines), the TOC extends off the page and the TOC sidebar is not scrollable.

@carolinemao carolinemao marked this pull request as draft June 3, 2022 02:10
@carolinemao
Copy link
Collaborator Author

@ryanrosenberg good catch! i thought it might be a problem but was hoping we didn't have any long enough TOCs :'( i'll do some research on how best to handle it, though scrollable is probably the way to go

@netlify
Copy link

netlify bot commented Jun 4, 2022 •
edited

❌ Deploy Preview for gorgeous-parfait-f2be7f failed.

Name Link
🔨 Latest commit 584656d
🔍 Latest deploy log https://app.netlify.com/sites/gorgeous-parfait-f2be7f/deploys/629bdbc4e8f85800080a2319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanrosenberg ryanrosenberg ryanrosenberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make table of contents on long pages sticky
2 participants
@carolinemao @ryanrosenberg