(v1.4) Fix mix task to pass pretty flag to custom codecs, add tests
#677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
@benwilson512 Just wondering what the ETA is for publishing a new release of v1.4? It would be nice to have this fix for a project I'm involved in, but my team is reluctant to pull a commit that isn't part of an official release. |
|
Done!
…On Thu, Jan 31, 2019 at 7:37 PM Nathan Hadfield ***@***.***> wrote:
@benwilson512 <https://github.com/benwilson512> Just wondering what the
ETA is for publishing a new release of v1.4? It would be nice to have this
fix for a project I'm involved in, but my team is reluctant to pull a
commit that isn't part of an official release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#677 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPICVoNkyXR8FlWfiZeboDvzrJ2F9pJks5vI4xJgaJpZM4aUikE>
.
|
|
Wow, that was fast! Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to v1.4 the fix for custom codecs in #676. (The current release of v1.4 has a bug that prevents custom JSON codecs from loading -- it doesn't convert the module name to an atom.)