Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firefox Drag'n'Drop Functionality #294

Merged
merged 3 commits into from Apr 15, 2021

Conversation

michaeljaltamirano
Copy link
Contributor

@michaeljaltamirano michaeljaltamirano commented Apr 13, 2021

Checklist:

  • No linting issues
  • Commits are compliant with commitizen
  • CI tests have passed
  • Documentation updated

Summary of changes

#290 broke Firefox compatibility. This PR adds a specific check to see if the Cypress runner broswer is Firefox to manually add 'change' into the drag'n'drop list of events because its presence was casing duplication for Chrome (see #276).

Draft PR instead of ready for review because we should probably add tests that try and repro some of these issues (either Chrome duplication, or Firefox upload functionality broken) so that we don't play whack-a-mole with patch PRs.

Linked issues

Closes #293

Copy link
Owner

@abramenal abramenal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!
I cannot recall the exact issue with tests in Firefox, but currently they are disabled. Will try to enable in in a separate PR

@abramenal abramenal mentioned this pull request Apr 14, 2021
4 tasks
@abramenal
Copy link
Owner

Okay, I have finally brought Firefox tests back. Now, please rebase your branch with latest main, so it'll run whole testing suite based on latest configuration changes. Hope it'll be all green 🤞

@michaeljaltamirano michaeljaltamirano marked this pull request as ready for review April 14, 2021 20:30
@michaeljaltamirano
Copy link
Contributor Author

Okay, I have finally brought Firefox tests back. Now, please rebase your branch with latest main, so it'll run whole testing suite based on latest configuration changes. Hope it'll be all green 🤞

Looks green 🙏 Hopefully no more issues pop up 😬

@abramenal abramenal merged commit 65a194e into abramenal:main Apr 15, 2021
@abramenal
Copy link
Owner

@all-contributors add @michaeljaltamirano for question and code

@allcontributors
Copy link
Contributor

@abramenal

I've put up a pull request to add @michaeljaltamirano! 🎉

@abramenal
Copy link
Owner

abramenal commented Apr 15, 2021

Coool stuff, it is all green now!
https://github.com/abramenal/cypress-file-upload/actions/runs/751210777

Thanks a lot for your effort @michaeljaltamirano, really appreciate that! 💪
I have deprecated v5.0.5 and published a new version containing your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Drag and drop not working as expected
2 participants