New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Firefox Drag'n'Drop Functionality #294
Fix Firefox Drag'n'Drop Functionality #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff!
I cannot recall the exact issue with tests in Firefox, but currently they are disabled. Will try to enable in in a separate PR
Okay, I have finally brought Firefox tests back. Now, please rebase your branch with latest |
… into firefox-drag-n-drop
Looks green 🙏 Hopefully no more issues pop up 😬 |
@all-contributors add @michaeljaltamirano for question and code |
I've put up a pull request to add @michaeljaltamirano! 🎉 |
Coool stuff, it is all green now! Thanks a lot for your effort @michaeljaltamirano, really appreciate that! 💪 |
Checklist:
Summary of changes
#290 broke Firefox compatibility. This PR adds a specific check to see if the Cypress runner broswer is Firefox to manually add
'change'
into the drag'n'drop list of events because its presence was casing duplication for Chrome (see #276).Draft PR instead of ready for review because we should probably add tests that try and repro some of these issues (either Chrome duplication, or Firefox upload functionality broken) so that we don't play whack-a-mole with patch PRs.
Linked issues
Closes #293