Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not preserve existing files #265

Merged
merged 1 commit into from Jan 20, 2021

Conversation

abramenal
Copy link
Owner

@abramenal abramenal commented Jan 20, 2021

Checklist:

  • No linting issues
  • Commits are compliant with commitizen
  • CI tests have passed
  • Documentation updated

Summary of changes

Do not preserve existing files.

This functionality was making sense when doing chaining calls, but now it is redundant. More than that, it is different from user may experience when doing same actions manually.

Linked issues

Closes #264

@abramenal abramenal self-assigned this Jan 20, 2021
@cypress
Copy link

cypress bot commented Jan 20, 2021



Test summary

60 0 0 0


Run details

Project cypress-file-upload
Status Passed
Commit d065f79
Started Jan 20, 2021 8:10 PM
Ended Jan 20, 2021 8:12 PM
Duration 01:57 💡
OS Linux Debian - 10.6
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@abramenal abramenal force-pushed the feature/dont-preserve-existing-files branch from f97dcff to d065f79 Compare January 20, 2021 20:07
@abramenal abramenal merged commit f63936d into main Jan 20, 2021
@abramenal abramenal deleted the feature/dont-preserve-existing-files branch January 20, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V5.0.0 breaks repeated uploads
1 participant