New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/multiple concurrent file uploads #251
Fix/multiple concurrent file uploads #251
Conversation
@tommy-anderson I saw your comment - would you be able to give these changes a test drive in your migration? Edit: You should be able to test by |
I've made small changes and tested it all locally. Great job @paulblyth, thank you! Next steps:
|
@all-contributors add @paulblyth for code |
I've put up a pull request to add @paulblyth! 🎉 |
@abramenal thanks for cleaning up and merging 🙌 |
Released in v5 btw |
Hey @abramenal - hoping this is an acceptable changeset. I know there's an open PR (#227) but that looks like it has gone stale and looks like it might have had some issues.
Closes #203
Closes #234
There's a little bit of ES6 in here and I've not contributed to a Cypress plugin before so let me know if that's bad practice - and please be extra critical :)
Note: I also had to commit changes in the recipes using
--no-verify
due to someeslint
errors, I didn't want to dig too much into those