Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/multiple concurrent file uploads #251

Merged
merged 14 commits into from Jan 16, 2021

Conversation

paulblyth
Copy link
Contributor

Hey @abramenal - hoping this is an acceptable changeset. I know there's an open PR (#227) but that looks like it has gone stale and looks like it might have had some issues.

Closes #203
Closes #234

There's a little bit of ES6 in here and I've not contributed to a Cypress plugin before so let me know if that's bad practice - and please be extra critical :)

Note: I also had to commit changes in the recipes using --no-verify due to some eslint errors, I didn't want to dig too much into those

@paulblyth
Copy link
Contributor Author

paulblyth commented Jan 14, 2021

@tommy-anderson I saw your comment - would you be able to give these changes a test drive in your migration?

Edit: You should be able to test by npm i git://github.com/paulblyth/cypress-file-upload.git#build/fix/multiple-file-uploads (it's the same branch just with the dist folder committed so you can install without having to worry about building)

README.md Show resolved Hide resolved
@paulblyth paulblyth changed the title Fix/multiple conccurent file uploads Fix/multiple concurrent file uploads Jan 15, 2021
@abramenal
Copy link
Owner

abramenal commented Jan 16, 2021

I've made small changes and tested it all locally. Great job @paulblyth, thank you!
It is also good that you mentioned issues with linting. Fixed all of them (I think), will work further on making the contribution process smooth.
And welcome to the contributors list ❤️

Next steps:

  • merge to master
  • wait for CI to be green (it will check the logic against some browsers in headed and headless modes)
  • release it tomorrow, boom! 💥

@abramenal abramenal merged commit 554b65a into abramenal:master Jan 16, 2021
@abramenal
Copy link
Owner

@all-contributors add @paulblyth for code

@allcontributors
Copy link
Contributor

@abramenal

I've put up a pull request to add @paulblyth! 🎉

@paulblyth paulblyth deleted the fix/multiple-file-uploads branch January 17, 2021 23:12
@paulblyth
Copy link
Contributor Author

@abramenal thanks for cleaning up and merging 🙌

@abramenal
Copy link
Owner

Released in v5 btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants