Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Make it clear that the fixture file can be any file #228

Merged
merged 1 commit into from Sep 6, 2020

Conversation

adrienjoly
Copy link
Contributor

...because I thought that, in the first example, the JSON file was metadata about the file to upload, and wasted a lot of time because of this misunderstanding.

I understood thanks to this StackOverflow answer: https://stackoverflow.com/a/62204487/592254

...because I thought that, in the first example, the JSON file was metadata about the file to upload, and wasted a lot of time because of this misunderstanding.

I understood thanks to this StackOverflow answer: https://stackoverflow.com/a/62204487/592254
@abramenal
Copy link
Owner

Hi @adrienjoly
Thanks for updating docs, this is really valuable!

@all-contributors add @adrienjoly for doc

@abramenal abramenal merged commit 02a8165 into abramenal:master Sep 6, 2020
@allcontributors
Copy link
Contributor

@abramenal

I've put up a pull request to add @adrienjoly! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants