Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo] in README.md fixtures -> fixture #211

Merged
merged 1 commit into from Aug 26, 2020
Merged

[Typo] in README.md fixtures -> fixture #211

merged 1 commit into from Aug 26, 2020

Conversation

Ebazhanov
Copy link
Contributor

Hello, Team!

This PR about fixing typo inside README.file
During my last installation, I found this issue when I was doing copy/paste of this block

const special = 'file.spss';
cy.fixtures(special, 'binary')
  .then(Cypress.Blob.binaryStringToBlob)
  .then((fileContent) => {
    cy.get('[data-cy="file-input"]').attachFile({ fileContent, filePath: special, encoding: 'utf-8' });
})

as you can see fixtures word is in plural form but should be in single according to the cypress documentation and

and inside the library
image

So it is the only way to make it work to use single form fixture

@abramenal thank you in advance for approving!

Best
Zhenja

@josephzidell josephzidell merged commit c61e9b0 into abramenal:master Aug 26, 2020
@josephzidell
Copy link
Contributor

@Ebazhanov Thank you for contributing!

@josephzidell
Copy link
Contributor

@all-contributors add @Ebazhanov for code

@allcontributors
Copy link
Contributor

@josephzidell

I've put up a pull request to add @Ebazhanov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants