Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 Array and string offset access syntax with curly braces is deprecated #797

Closed
roko91 opened this issue Sep 30, 2019 · 1 comment
Closed

Comments

@roko91
Copy link

roko91 commented Sep 30, 2019

First thank you for the great package!

When testing PHP 7.4.0beta4 I encountered the following exception:

In HmacSha1.php line 15:

During class fetch: Uncaught ErrorException: Array and string offset access syntax with curly braces is deprecated in /home/test/test/vendor/abraham/twitteroauth/src/SignatureMethod.php:61
Stack trace:
#0 /home/test/test/vendor/composer/ClassLoader.php(444): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError()
#1 /home/test/test/vendor/composer/ClassLoader.php(444): include()
#2 /home/test/test/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#4 /home/test/test/vendor/abraham/twitteroauth/src/HmacSha1.php(15): spl_autoload_call()
#5 /home/test/test/vendor/composer/ClassLoader.php(444): include('/home/test/tes...')
#6 /home/test/test/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
#7

I think it's pretty self-explanatory - for array and string offset access curly braces should be replaced with square braces for future PHP versions.

I will create PR for this tomorrow.

@roko91 roko91 closed this as completed Sep 30, 2019
@roko91
Copy link
Author

roko91 commented Sep 30, 2019

Never mind I just saw someone else did already create PR: #788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant