Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing string offsets using curly braces has been deprecated in PHP 7.4. #788

Merged
merged 1 commit into from Nov 29, 2019
Merged

Accessing string offsets using curly braces has been deprecated in PHP 7.4. #788

merged 1 commit into from Nov 29, 2019

Conversation

hkiciy
Copy link
Contributor

@hkiciy hkiciy commented Aug 12, 2019

Replace curly brackets to square brackets.

@norbertmocsnik
Copy link

Looking forward to this fix

@norbertmocsnik
Copy link

norbertmocsnik commented Nov 29, 2019

Without this patch PHP 7.4 throws

Deprecated: Array and string offset access syntax with curly braces is deprecated in /var/www/web/vendor/abraham/twitteroauth/src/SignatureMethod.php on line 61

@abraham abraham merged commit 534e2d0 into abraham:master Nov 29, 2019
@abraham
Copy link
Owner

abraham commented Nov 29, 2019

Thanks!

@tolry
Copy link

tolry commented Dec 9, 2019

Hi @abraham,

if I'm not mistaken, this change hasn't been published yet, right? Could you please make a release for this? I would prefer a release over dev-master in my composer.json in order to have this working without deprecation warnings in php 7.4.

Thanks for a great library! 👍

@tolry
Copy link

tolry commented Dec 9, 2019

Sorry, I just saw that this has only been merged a couple of days ago (previously only looked at the commit date) - no need to rush here, I will pin to a commit hash for now :-)

@abraham
Copy link
Owner

abraham commented Dec 10, 2019

These changes should already be released under v1.1.0.

@tolry
Copy link

tolry commented Dec 10, 2019

Thanks for the reply ... 🤔 strange with ^1.1.0 it seems to work, with my old version constraint it didn't work, sorry for the hassle

@akshayshrivastav866
Copy link

i am still getting this error, any update yet?

@UVLabs
Copy link

UVLabs commented Jun 29, 2020

@akshayshrivastav866 You'd have to update to v1.0.1, I checked the code for that tag and it doesn't seem like the curly brackets still exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants