Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exceptions for non-2XX HTTP responses #682

Closed
abraham opened this issue Jul 3, 2018 · 2 comments
Closed

Throw exceptions for non-2XX HTTP responses #682

abraham opened this issue Jul 3, 2018 · 2 comments
Labels
Task
Milestone
v2.0

Comments

@abraham
Copy link
Owner

abraham commented Jul 3, 2018 •
edited

Users shouldn't have to check if the response code is a HTTP 2XX.
@abraham abraham added the Task label Jul 3, 2018
@abraham abraham mentioned this issue Jul 3, 2018
Closed
11 tasks
@abraham abraham added this to the v2.0 milestone Jul 3, 2018
@sp4ceb4r sp4ceb4r mentioned this issue Jun 22, 2019
Closed
@eKevinHoang
Copy link

@abraham I think it'd be better if it has an option for this.

Because some of API, status is non-2xx doesn't mean it's error, such as 'account_activity/all/:env_name/subscriptions' for the case user's already subscribed.

@abraham abraham changed the title Throw exceptions for non-2XX responses Throw exceptions for non-2XX HTTP responses Mar 22, 2022
@abraham
Copy link
Owner Author

abraham commented Jul 24, 2023

TwitterOAuth is in maintenance mode and major improvements are no longer planned. #1188

@abraham abraham closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@abraham @eKevinHoang