Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12 support #4

Closed
bdistin opened this issue Jul 30, 2019 · 1 comment
Closed

Node 12 support #4

bdistin opened this issue Jul 30, 2019 · 1 comment
Labels

Comments

@bdistin
Copy link

bdistin commented Jul 30, 2019

zlib-sync will not build when using node v12.x.

\node_modules\zlib-sync\src\zlib_sync.cc(72): error C2661: 'v8::Value::BooleanValue': no overloaded function takes 0 arguments [\node_modules\zlib-sync\build\zlib_sync.vcxproj]
\node_modules\zlib-sync\src\zlib_sync.cc(76): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [\node_modules\zlib-sync\build\zlib_sync.vcxproj]
  \.node-gyp\12.7.0\include\node\v8.h(2576): note: see declaration of 'v8::Value::Int32Value' (compiling source file ..\src\zlib_sync.cc)
\node_modules\zlib-sync\src\zlib_sync.cc(165): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [\node_modules\zlib-sync\build\zlib_sync.vcxproj]
  \.node-gyp\12.7.0\include\node\v8.h(2576): note: see declaration of 'v8::Value::Int32Value' (compiling source file ..\src\zlib_sync.cc)
\node_modules\zlib-sync\src\zlib_sync.cc(170): error C2661: 'v8::Value::ToString': no overloaded function takes 0 arguments [\node_modules\zlib-sync\build\zlib_sync.vcxproj]
\node_modules\zlib-sync\src\zlib_sync.cc(170): error C2512: 'v8::String::Utf8Value': no appropriate default constructor available [\node_modules\zlib-sync\build\zlib_sync.vcxproj]
  \node_modules\zlib-sync\src\zlib_sync.cc(170): note: No constructor could take the source type, or constructor overload resolution was ambiguous
\node_modules\zlib-sync\src\zlib_sync.cc(178): error C2660: 'v8::Value::Int32Value': function does not take 0 arguments [\node_modules\zlib-sync\build\zlib_sync.vcxproj]
  \.node-gyp\12.7.0\include\node\v8.h(2576): note: see declaration of 'v8::Value::Int32Value' (compiling source file ..\src\zlib_sync.cc)
\node_modules\zlib-sync\src\zlib_sync.cc(204): error C2660: 'v8::FunctionTemplate::GetFunction': function does not take 0 arguments [\node_modules\zlib-sync\build\zlib_sync.vcxproj]
  \.node-gyp\12.7.0\include\node\v8.h(5955): note: see declaration of 'v8::FunctionTemplate::GetFunction' (compiling source file ..\src\zlib_sync.cc)
\node_modules\zlib-sync\src\zlib_sync.cc(204): error C2661: 'v8::Object::Set': no overloaded function takes 1 arguments [\node_modules\zlib-sync\build\zlib_sync.vcxproj]

Would be great to have a version that works for node 12!

@abalabahaha
Copy link
Owner

#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants