From 7b16edf2d6aa32275d968c9d0d777ba30f2152b1 Mon Sep 17 00:00:00 2001 From: Ollie Jones <35707991+oathompsonjones@users.noreply.github.com> Date: Mon, 2 Dec 2019 18:06:20 +0000 Subject: [PATCH 1/4] Changed type for EmbedBase.timestamp Type should by `string | Date` in order to allow for doing `timestamp: new Date()` --- index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.d.ts b/index.d.ts index f48b4b1c0..c75eee053 100644 --- a/index.d.ts +++ b/index.d.ts @@ -316,7 +316,7 @@ declare namespace Eris { title?: string; description?: string; url?: string; - timestamp?: string; + timestamp?: string | Date; color?: number; footer?: { text: string; icon_url?: string; proxy_icon_url?: string }; image?: { url?: string; proxy_url?: string; height?: number; width?: number }; From 4f322891947a252bd506037403bc73ae8f6c62c3 Mon Sep 17 00:00:00 2001 From: Ollie Jones <35707991+oathompsonjones@users.noreply.github.com> Date: Mon, 2 Dec 2019 21:35:23 +0000 Subject: [PATCH 2/4] Correction to previous type change. `timestamp`s do not work with `string`s at all, the data type must be `Date` --- index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.d.ts b/index.d.ts index c75eee053..bb592814f 100644 --- a/index.d.ts +++ b/index.d.ts @@ -316,7 +316,7 @@ declare namespace Eris { title?: string; description?: string; url?: string; - timestamp?: string | Date; + timestamp?: Date; color?: number; footer?: { text: string; icon_url?: string; proxy_icon_url?: string }; image?: { url?: string; proxy_url?: string; height?: number; width?: number }; From 1ad6f0e018b8632d96e6c705f0f26a282e385c60 Mon Sep 17 00:00:00 2001 From: Ollie Jones <35707991+oathompsonjones@users.noreply.github.com> Date: Tue, 3 Dec 2019 06:35:13 +0000 Subject: [PATCH 3/4] Changed back to string | Date Stop devs gettings loads of errors if they have already been passing strings not dates --- index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.d.ts b/index.d.ts index bb592814f..c75eee053 100644 --- a/index.d.ts +++ b/index.d.ts @@ -316,7 +316,7 @@ declare namespace Eris { title?: string; description?: string; url?: string; - timestamp?: Date; + timestamp?: string | Date; color?: number; footer?: { text: string; icon_url?: string; proxy_icon_url?: string }; image?: { url?: string; proxy_url?: string; height?: number; width?: number }; From 8b01402ebffea126970b4128c93c0694b4946d91 Mon Sep 17 00:00:00 2001 From: Ollie Jones <35707991+oathompsonjones@users.noreply.github.com> Date: Tue, 3 Dec 2019 19:10:40 +0000 Subject: [PATCH 4/4] Swap around Date and string Co-Authored-By: Skillz4Killz <23035000+Skillz4Killz@users.noreply.github.com> --- index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.d.ts b/index.d.ts index c75eee053..dfeb93f2f 100644 --- a/index.d.ts +++ b/index.d.ts @@ -316,7 +316,7 @@ declare namespace Eris { title?: string; description?: string; url?: string; - timestamp?: string | Date; + timestamp?: Date | string; color?: number; footer?: { text: string; icon_url?: string; proxy_icon_url?: string }; image?: { url?: string; proxy_url?: string; height?: number; width?: number };