Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 4 as an option for Activity#type #599

Merged
merged 3 commits into from Jan 1, 2020
Merged

Added 4 as an option for Activity#type #599

merged 3 commits into from Jan 1, 2020

Conversation

oathompsonjones
Copy link
Contributor

Also edited GamePresence#type to match

@oathompsonjones
Copy link
Contributor Author

Has anybody found any difference between Activity and GamePresence when in use? From what I can see it might be better to just have one interface for them as they seem to return the same values in practice.

@alex-taxiera
Copy link
Contributor

@oathompsonjones I'll take a look at this over the next few weeks. My bot deals exclusively with presences, but I never had to pay much attention to Activity before.

@abalabahaha abalabahaha merged commit a4fe81f into abalabahaha:dev Jan 1, 2020
@oathompsonjones oathompsonjones deleted the patch-2 branch January 2, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalabahaha abalabahaha abalabahaha approved these changes

@Skillz4Killz Skillz4Killz Skillz4Killz approved these changes

Assignees
No one assigned
Labels
typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oathompsonjones @alex-taxiera @abalabahaha @Skillz4Killz