Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bannerURL/splashURL typings #597

Merged
merged 5 commits into from Jan 1, 2020
Merged

Added bannerURL/splashURL typings #597

merged 5 commits into from Jan 1, 2020

Conversation

oathompsonjones
Copy link
Contributor

No description provided.

reboxer
reboxer reviewed Dec 17, 2019
View reviewed changes
Copy link
Contributor

@reboxer reboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also add splashURL?

Skillz4Killz
Skillz4Killz reviewed Dec 21, 2019
View reviewed changes
Copy link
Contributor

@Skillz4Killz Skillz4Killz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ? to mark something as optional makes typescript understand it as if it is undefined. The actual behavior in Eris never allows this to be undefined. It marks it as null making this optional and not explicitly null can cause issues to end users.

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
oathompsonjones and others added 2 commits December 21, 2019 21:05
@oathompsonjones @Skillz4Killz
null instead of undefined
1e6344e 
Co-Authored-By: Skillz4Killz <23035000+Skillz4Killz@users.noreply.github.com>
@oathompsonjones @Skillz4Killz
null instead of undefined
ffcb47d 
Co-Authored-By: Skillz4Killz <23035000+Skillz4Killz@users.noreply.github.com>
@oathompsonjones
Copy link
Contributor Author

Wasn't aware those would return null as opposed to undefined, thanks for letting me know.

@abalabahaha abalabahaha changed the title Added bannerURL Added bannerURL/splashURL typings Dec 31, 2019
@abalabahaha abalabahaha merged commit f4ba182 into abalabahaha:dev Jan 1, 2020
@oathompsonjones oathompsonjones deleted the patch-1 branch January 2, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reboxer reboxer reboxer left review comments

@abalabahaha abalabahaha abalabahaha approved these changes

@Skillz4Killz Skillz4Killz Skillz4Killz approved these changes

Assignees
No one assigned
Labels
bug typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oathompsonjones @abalabahaha @reboxer @Skillz4Killz