Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix voice channel leave docs/typings #590

Merged
merged 6 commits into from Dec 6, 2019
Merged

fix voice channel leave docs/typings #590

merged 6 commits into from Dec 6, 2019

Conversation

Skillz4Killz
Copy link
Contributor

@Skillz4Killz Skillz4Killz commented Dec 4, 2019 •
edited

This PR always sends a valid memberin voiceChannelLeave event.
It also removes Category and Text Channels from the channel type in jsdocs
It also makes Collection.find() allowed to be undefined when there is nothing found.

image

image

apacheli
apacheli suggested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@apacheli apacheli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably return the raw member data from the gateway instead of null

@abalabahaha abalabahaha merged commit 1c395d2 into abalabahaha:dev Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apacheli apacheli apacheli requested changes

@abalabahaha abalabahaha abalabahaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skillz4Killz @abalabahaha @apacheli