Type fixes

[DonovanDMC]

The OldChannel object, which is used in the channelUpdate event is missing the nsfw, and type properties, which are present in the jsdoc.

[Skillz4Killz]

More missing types from oldChannel

[DonovanDMC]

if we really wanted to, we could get really specific with the type parameter so only the properties that would be on the specific channel are there, though that would probably be done in the event definition instead.

[Skillz4Killz]

@DonovanDMC Silly question, but how does one even change the channel type? Is that even possible? I didn't know discord supported that.

[DonovanDMC]

@DonovanDMC Silly question, but how does one even change the channel type? Is that even possible? I didn't know discord supported that.

I don't think you can change the type of channels.

[Skillz4Killz]

Then i think the best way to handle this would be to remove the type property from OldMessage and the typings. type can never change.

[Zoddo]

A text channel can be converted to a news channel and vice versa.

[DonovanDMC]

A text channel can be converted to a news channel and vice versa.

True, forgot about that.

[Skillz4Killz]

Ahh very good point so we do need the type property on the oldChannel incase the text-news types change.

[DonovanDMC]

Decided to convert the types back to just OldChannel, because it's much cleaner, and a lot less of a mess since nothing else is working. As well made some changes to guildRoleUpdate, as it was missing properties, and they were all optional since they were using RoleOptions.