Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense Support #577

Merged
merged 2 commits into from Dec 1, 2019
Merged

Intellisense Support #577

merged 2 commits into from Dec 1, 2019

Conversation

hiimjustin000
Copy link
Contributor

This will allow intellisense support. UGH!!! was always wondering why it wouldn't autocomplete...

@LJNeon
Copy link
Contributor

LJNeon commented Nov 28, 2019

Please change your PR to merge into dev instead of master.

@hiimjustin000 hiimjustin000 changed the base branch from master to dev November 28, 2019 21:26
@Skillz4Killz
Copy link
Contributor

Skillz4Killz commented Nov 29, 2019

I am not sure if this change has any impact. Please someone with a JS bot, should test this. I thought by default, typings are read from the root file.

EDIT: Confirmed by Donovan as well on a new project in JS the intellisense worked.

@DonovanDMC
Copy link
Contributor

This makes no difference with my testing.
image

By default, a index.d.ts is looked for.

@abalabahaha
Copy link
Owner

I would love to find out what causes TypeScript to do this, but I also don't care enough to... Oh well, seems backwards compatible.

@abalabahaha abalabahaha merged commit 09c118b into abalabahaha:dev Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants