Promisified Guild#fetchAllMembers #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apacheli
suggested changes
Nov 26, 2019
abalabahaha
requested changes
Dec 1, 2019
abalabahaha
approved these changes
Dec 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a basic test to make sure this works, more testing may or may not be useful. I used the
requestTimeoutclient option for this, as I don't believe that making a new option is worth it here and it seemed to be the best fitting of all existing options. I also never reject the promise as the point here was to mirror previous behavior, only with a Promise that resolves at the end. I'm open to feedback on those two points.