Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new constants and unify Constants usage #569

Merged
merged 8 commits into from Nov 25, 2019
Merged

Adds new constants and unify Constants usage #569

merged 8 commits into from Nov 25, 2019

Conversation

Khaaz
Copy link
Contributor

@Khaaz Khaaz commented Nov 23, 2019

This PR does a general code cleanup:

  • removes hardcoded values for channel.type and message.type
  • uniformises Constants usage in the lib (always destructure constants).
    It renames usage of OPCode to GatewayOPCodes or VoiceOPCodes and makes it more explicit.

updates typings with new constants

abalabahaha
abalabahaha requested changes Nov 24, 2019
View reviewed changes
lib/Constants.js Outdated Show resolved Hide resolved
lib/Constants.js Outdated Show resolved Hide resolved
lib/Constants.js Outdated Show resolved Hide resolved
@Khaaz
Copy link
Contributor Author

Khaaz commented Nov 24, 2019

Also uses ChannelTypes in Shard.js.

@abalabahaha abalabahaha merged commit 46f2e23 into abalabahaha:dev Nov 25, 2019
@Khaaz Khaaz deleted the patch2 branch December 1, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalabahaha abalabahaha abalabahaha approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Khaaz @abalabahaha