Document flags for editMessage #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abalabahaha
reviewed
Nov 23, 2019
abalabahaha
approved these changes
Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in discord/discord-api-docs#1003 we can now pass flags in editMessage to set/unset SUPRESS_EMBED flags.
I simply documented this change since we can directly use content in the
editMessagemethod to apply the flags to the message (content.flags).The
editMessagewasalso edited to allow passing onlycontent.flagsThis PR also updates typings
Note on
editMessage:content.contentwill just edit the content of the embed without affecting the embed (as expected)content.embedwill just edit the embed without affecting the content (as expected)