Typings File Enhancements #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into rewrite-typings
eritbh
approved these changes
Nov 16, 2019
abalabahaha
approved these changes
Nov 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings about a few fixes to the typings file.
Several constants were missing and were not typed strictly allowing potential bugs or just bad quality of life for developers. As an example, now we will have easy access to autocompletion for most constants.
Member typings that were discussed in Prevent Member.activities to be overriden by undefined values #555 have also been patched. Note: I don't used these in depth, so I am not 100% if it is perfect. Would love any reviews from those that use Activities in their bots. The typings I made came from evals I ran on my server with my bot.
Fixes
channelCreatetypings by allowing the passing of channelCreate options. Until theparentIDis removed, we can keep thestringoption as well.Since this became quite a bunch of fixes into the typings file, I decided to take the initiative and try to add some more consistency to the files. Please let me know how you feel about these changes. I believe they help make typings much easier to read and maintain going forward.
a. Remove the redundant
publicon everything. This is by default anyway, plus we have nothing labelled private here.b. Consistent spacing and formatting in the entire line.
c. Sometimes lines/props were being separated with
;and other times with,so I made them all use;to keep consistant