Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissionOverwrites option when creating guild channels #544

Merged
merged 2 commits into from Oct 18, 2019

Conversation

Astraeus-
Copy link
Contributor

Adds the option to specify an array of overwrite objects to be applied when creating a guild channel as specified in the Discord API Documentation.

I'm not experienced with writing typings for TypeScript, so I did not update any of those.

Copy link
Owner

@abalabahaha abalabahaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested? I'd expect this to fail because PermissionOverwrite#toJSON() omits the ID...

lib/Client.js Outdated Show resolved Hide resolved
@Astraeus-
Copy link
Contributor Author

I tested creating a channel with permission overwrites specified as per the Discord docs and it worked as expected.

@abalabahaha
Copy link
Owner

Ah, you meant raw overwrite objects.

@abalabahaha abalabahaha merged commit 4fd75ec into abalabahaha:dev Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants