Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint #540

Merged
merged 5 commits into from Oct 13, 2019
Merged

Fix eslint #540

merged 5 commits into from Oct 13, 2019

Conversation

alex-taxiera
Copy link
Contributor

  • Added eslint as a dev dep to allow script to run without
  • Overode 2 rules:
    1. no-prototype-builtins: ignoring, we don't need this
    2. require-atomic-updates: set to warn, seems useful but has some false positives

@abalabahaha abalabahaha merged commit 36986b1 into abalabahaha:dev Oct 13, 2019
@alex-taxiera alex-taxiera deleted the fix-eslint-script branch June 16, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alex-taxiera @abalabahaha