Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for channel following and messageCreate type 12. #514

Merged
merged 9 commits into from Aug 21, 2019

Conversation

Khaaz
Copy link
Contributor

@Khaaz Khaaz commented Aug 7, 2019

This PR adds support for the new channel follow feature according to: discord/discord-api-docs#1051

This was tested so it support messageCreate type 12 and adds the new messageReference and flags properties to the message object.

A MessageFlags constant is also added in the Constants file.

@Khaaz
Copy link
Contributor Author

Khaaz commented Aug 7, 2019

I fixed the naming and added the documentation.
This is pretty much ready, the last question concerns the message content. I used the channel mention to try to replicate discord showing the server where the channel is from. However should we use the raw channel name here?

lib/structures/Message.js Outdated Show resolved Hide resolved
lib/structures/Message.js Outdated Show resolved Hide resolved
lib/structures/Message.js Outdated Show resolved Hide resolved
@Khaaz
Copy link
Contributor Author

Khaaz commented Aug 13, 2019

Fixed the documentation and changed the content to the raw data.content without the channel mention.
I thought so as well, it makes more sense to just use the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants