Added support for Node HTTP(S) Agent #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minigugus
changed the title
eritbh
reviewed
Mar 8, 2019
| if (this.options.agent && !(this.options.ws && this.options.ws.agent)) { | ||
| this.options.ws = this.options.ws || {}; | ||
| this.options.ws.agent = this.options.agent; | ||
| } |
There was a problem hiding this comment.
The jsdoc comment for the client constructor should be updated to reflect this new option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #473
A very simple PR that add support for HTTP Agents, allowing requests to be proxied by many kind of proxies (with
http-proxy-agentorsocks-proxy-agentfor instance).