Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated for loops over Objects to check hasOwnProperty #396

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

bmendric
Copy link
Contributor

Discovered problem with how the eris handles for ... in loops for Object once a custom Object.prototype has been defined. Solution was to verify Object.hasOwnProperty().

All for loops in the library were examined and, if needed, corrected. There were a couple of exceptions, which I did not modify, that used Object.keys() method to "automatically" correct this issue.

Credit to Notice Me on Discord for figuring this one out.

@abalabahaha abalabahaha merged commit d02ca9f into abalabahaha:dev Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants