Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MessageContent instead of string in TS typings #394

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Use MessageContent instead of string in TS typings #394

merged 1 commit into from
Jun 11, 2018

Conversation

retrixe
Copy link
Contributor

@retrixe retrixe commented Jun 8, 2018

Since Eris' CommandClient supports the CommandGenerator returning an Object, this commit edits the TypeScript typings to support a function returning one.

Since Eris' CommandClient supports the CommandGenerator returning an Object, this commit edits the TypeScript typings to support a function returning one.
@retrixe retrixe changed the base branch from master to dev June 8, 2018 12:54
@retrixe
Copy link
Contributor Author

retrixe commented Jun 8, 2018

* @arg {Function | String | Array<Function | String>} generator A response string, array of functions or strings, or function that generates a string or array of strings when called.

* @arg {Function | String | Array<Function | String>} generator A response string, array of functions or strings, or function that generates a string or array of strings when called.

Documentation changes required here?

@abalabahaha
Copy link
Owner

The JSDoc generator has a couple issues with custom types, seems fine as is

@abalabahaha abalabahaha merged commit 1334ec8 into abalabahaha:dev Jun 11, 2018
@retrixe retrixe deleted the patch-1 branch June 13, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants