Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message.cleanContent fails on Discord-generated messages and custom emojis #377

Closed
Runi-c opened this issue Apr 9, 2018 · 0 comments
Closed

Message.cleanContent fails on Discord-generated messages and custom emojis #377

Runi-c opened this issue Apr 9, 2018 · 0 comments
Labels
bug

Comments

@Runi-c
Copy link
Contributor

Runi-c commented Apr 9, 2018

By Discord-generated messages I mean the ones for pinning a message in a channel and for a member joining the server. In these cases the mention <@id> remains in cleanContent when it should be replaced by username.

Custom emojis are a similar story, they should be replaced by the emoji name i.e. <:custom:id> -> :custom:
@abalabahaha abalabahaha added the bug label Apr 9, 2018
@TheRacingLion TheRacingLion mentioned this issue Apr 10, 2018
Merged
nandub added a commit to nandub/eris that referenced this issue May 22, 2018
@nandub
Merge remote-tracking branch 'upstream/master'
ec881f1 
* upstream/master:
  0.8.6
  Bump ws dependency
  Prevent command overwriting in CommandClient (abalabahaha#389)
  Fix PermissionOverwrite docs, lint
  Add role.mentionable to guildRoleUpdate (abalabahaha#387)
  Remove global reaction ratelimit (abalabahaha#388)
  Update Message.cleanContent (fix abalabahaha#377) (abalabahaha#378)
  Send WS close code 1000 on Shard.disconnect() (abalabahaha#383)
  Change how duplicate presences are detected (abalabahaha#376)
  Fix OggOpusTransformer for multi-track files (abalabahaha#380)
  Added closeVoiceConnection() (abalabahaha#368)
  Add new system messages (abalabahaha#375)
  Remove ImageSizes array and fix minimum image size
  Typings: Renamed dynamicIconURL in User to dynamicAvatarURL (abalabahaha#373)
nandub added a commit to nandub/eris that referenced this issue May 22, 2018
@nandub
Merge remote-tracking branch 'upstream/master' into develop
21313c1 
* upstream/master:
  0.8.6
  Bump ws dependency
  Prevent command overwriting in CommandClient (abalabahaha#389)
  Fix PermissionOverwrite docs, lint
  Add role.mentionable to guildRoleUpdate (abalabahaha#387)
  Remove global reaction ratelimit (abalabahaha#388)
  Update Message.cleanContent (fix abalabahaha#377) (abalabahaha#378)
  Send WS close code 1000 on Shard.disconnect() (abalabahaha#383)
  Change how duplicate presences are detected (abalabahaha#376)
  Fix OggOpusTransformer for multi-track files (abalabahaha#380)
  Added closeVoiceConnection() (abalabahaha#368)
  Add new system messages (abalabahaha#375)
  Remove ImageSizes array and fix minimum image size
  Typings: Renamed dynamicIconURL in User to dynamicAvatarURL (abalabahaha#373)
ErisPRUpdateBot pushed a commit to ErisPRUpdateBot/eris that referenced this issue May 28, 2022
@DonovanDMC
Merge pull request abalabahaha#377 from ErisPRUpdateBot/donovandmc/in…
35abfb1 
…teractions-rewrite/interactions/0fe127273d3ed27c85d35a1ee8177237cda4dbb3

Remote Update (interactions): donovandmc/interactions-rewrite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abalabahaha @Runi-c