Typings: Renamed dynamicIconURL in User to dynamicAvatarURL #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually that doesn't have to be removed, just renamed to dynamicAvatarURL. I guess it was copy pasted from somewhere else or a typo. |
|
Yep lol... Should have checked if dynamicAvatarURL existed. |
TheAkio
changed the title
nandub
added a commit
to nandub/eris
that referenced
this pull request
May 22, 2018
* upstream/master: 0.8.6 Bump ws dependency Prevent command overwriting in CommandClient (abalabahaha#389) Fix PermissionOverwrite docs, lint Add role.mentionable to guildRoleUpdate (abalabahaha#387) Remove global reaction ratelimit (abalabahaha#388) Update Message.cleanContent (fix abalabahaha#377) (abalabahaha#378) Send WS close code 1000 on Shard.disconnect() (abalabahaha#383) Change how duplicate presences are detected (abalabahaha#376) Fix OggOpusTransformer for multi-track files (abalabahaha#380) Added closeVoiceConnection() (abalabahaha#368) Add new system messages (abalabahaha#375) Remove ImageSizes array and fix minimum image size Typings: Renamed dynamicIconURL in User to dynamicAvatarURL (abalabahaha#373)
nandub
added a commit
to nandub/eris
that referenced
this pull request
May 22, 2018
* upstream/master: 0.8.6 Bump ws dependency Prevent command overwriting in CommandClient (abalabahaha#389) Fix PermissionOverwrite docs, lint Add role.mentionable to guildRoleUpdate (abalabahaha#387) Remove global reaction ratelimit (abalabahaha#388) Update Message.cleanContent (fix abalabahaha#377) (abalabahaha#378) Send WS close code 1000 on Shard.disconnect() (abalabahaha#383) Change how duplicate presences are detected (abalabahaha#376) Fix OggOpusTransformer for multi-track files (abalabahaha#380) Added closeVoiceConnection() (abalabahaha#368) Add new system messages (abalabahaha#375) Remove ImageSizes array and fix minimum image size Typings: Renamed dynamicIconURL in User to dynamicAvatarURL (abalabahaha#373)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By accident I noticed that the function dynamicIconURL() for User is defined in the typings but it's not really in the source code.