Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eris.VERSION #364

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Add Eris.VERSION #364

merged 2 commits into from
Feb 28, 2018

Conversation

auguwu
Copy link
Contributor

@auguwu auguwu commented Feb 24, 2018

This pull request is telling the bot/code that Eris is x version (x = Current Release on NPM/package.json)

@Brayzure
Copy link
Contributor

Helpful I guess, but what's so challenging about just require('./package.json').version? It's a single line, and your solution still wouldn't be documented anywhere afaik.

@abalabahaha abalabahaha changed the base branch from master to dev February 25, 2018 01:53
@abalabahaha abalabahaha changed the title Add Eris.Version Add Eris.VERSION Feb 28, 2018
@abalabahaha abalabahaha merged commit a9564f4 into abalabahaha:dev Feb 28, 2018
nandub added a commit to nandub/eris that referenced this pull request Mar 14, 2018
* upstream/master:
  0.8.5
  Add option to manually offset ratelimiter
  Add Eris.VERSION (abalabahaha#364)
  Avoid negative average latency (fix abalabahaha#365)
  Code/docs tidying
  Check for missing msg.author in CommandClient (fix abalabahaha#362)
  Fix voice receive stream cleanup (fix abalabahaha#359)
  Fix Spotify presence update caching (abalabahaha#363)
  Update editStatus docs (abalabahaha#361)
  Expose userID for CommandClient reaction buttons
  Expose activity and application properties in Message
  Fix user caching for ban events
nandub added a commit to nandub/eris that referenced this pull request Mar 14, 2018
* upstream/master:
  0.8.5
  Add option to manually offset ratelimiter
  Add Eris.VERSION (abalabahaha#364)
  Avoid negative average latency (fix abalabahaha#365)
  Code/docs tidying
  Check for missing msg.author in CommandClient (fix abalabahaha#362)
  Fix voice receive stream cleanup (fix abalabahaha#359)
  Fix Spotify presence update caching (abalabahaha#363)
  Update editStatus docs (abalabahaha#361)
  Expose userID for CommandClient reaction buttons
  Expose activity and application properties in Message
  Fix user caching for ban events
@auguwu auguwu mentioned this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants