Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deserialization for Nullable types. #539

Merged
merged 1 commit into from Oct 26, 2020
Merged

Fix deserialization for Nullable types. #539

merged 1 commit into from Oct 26, 2020

Conversation

brendandburns
Copy link
Contributor

Octal (and Hex and other format) deserialization assumes that the type is concrete, but it should also work for Nullable types.

#ref kubernetes-client/csharp#500

Thanks!

@aaubry aaubry merged commit 7714d0d into aaubry:master Oct 26, 2020
@aaubry
Copy link
Owner

aaubry commented Oct 26, 2020

Thanks!

@brendandburns
Copy link
Contributor Author

Thanks for merging! Any ideas about when this will make it into a release?

@aaubry
Copy link
Owner

aaubry commented Oct 26, 2020

I can create a release next thursday, 2020-10-29.

@brendandburns
Copy link
Contributor Author

Fantastic, that's awesome! many thanks!

@aaubry
Copy link
Owner

aaubry commented Nov 19, 2020

I'm sorry I was unable to release when I expected to. I've just published release 9.1.0 that includes this fix. Thanks for your patience!

@aaubry aaubry mentioned this pull request Nov 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brendandburns @aaubry