Add anchor/alias support in JsonEventEmitter #490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, serializing the following YAML with
.JsonCompatible()
throwsUnhandled exception. System.NotSupportedException: Aliases are not supported in JSON
:This PR adds support for anchors and aliases, such that it produces JSON replicating the anchored value:
It makes it very close to other frameworks, e.g. https://www.convertjson.com/yaml-to-json.htm (modulo quoted numeric value
"1"
in our case when deserializing-then-reserilizing a dynamic object vs. unquoted1
in theirs).Also:
Serialization\SerializerBuilder.cs(557,64): warning CS8625: Cannot convert null literal to non-nullable reference type.
YamlDotNet/Serialization/YamlMember.cs
to match class name:YamlDotNet/Serialization/YamlMemberAttribute.cs
.YamlDotNet/Core/EmitterSettings.cs
.