Add support for private properties. #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the `ReadablePropertiesTypeInspector` to handle non-public properties. While it is possible for the user to provide custom type inspectors, it's not easy for these to surface additional properties. An alternative approach to the work here would be to make `ReflectionPropertyDescriptor` protected and unseal `ReadablePropertiesTypeInspector`. The `BuilderSkeleton` would also need to allow the root `ITypeInspector`(s) to be customized.
|
I'm sorry it took so long to review this PR, but thanks anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: It can be necessary to serialize and deserialize
internal(or more private) properties in order to restore object state. It is desirable to restrict access to these properties to encapsulate functionality.Extend the
ReadablePropertiesTypeInspectorto handle non-public properties.While it is possible for the user to provide custom type inspectors, it's not easy for these to surface additional properties. An alternative approach to the work here would be to make
ReflectionPropertyDescriptorprotected and unsealReadablePropertiesTypeInspector. The BuilderSkeletonwould also need to allow the rootITypeInspector`(s) to be customized.This approach surfaces the non-public properties while leaving any more complex filtering (such as only serializing them if they have an extra attribute) to downstream type inspectors.