Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YamlMappingNode does not preserve the order of the keys #414

Closed
aaubry opened this issue Jun 17, 2019 · 5 comments · Fixed by #542
Closed

YamlMappingNode does not preserve the order of the keys #414

aaubry opened this issue Jun 17, 2019 · 5 comments · Fixed by #542
Labels
bug good-first-issue This should be easy to pick up if you want to get started.

Comments

@aaubry
Copy link
Owner

aaubry commented Jun 17, 2019

When loading a YAML stream, the order of the key-value pairs should be preserved by YamlMappingNode.
@aaubry aaubry added bug good-first-issue This should be easy to pick up if you want to get started. labels Jun 17, 2019
@a2937
Copy link
Contributor

a2937 commented Feb 7, 2020

Is this issue still available? I wanna try to resolve it.

@aaubry
Copy link
Owner Author

aaubry commented Feb 7, 2020

Yes it is available. Thanks for your interest! Let me know if you have questions.

@a2937
Copy link
Contributor

a2937 commented Feb 16, 2020

The serialization aspect is being a bit of an issue. I got the two tests to give me output, but the problem is that the tests say they aren't equal however I genuinely can't tell the difference. Maybe you can.

@aaubry
Copy link
Owner Author

aaubry commented Feb 16, 2020

Can you provide more details ? Which tests are failing ? Can you share your changes ?

@a2937
Copy link
Contributor

a2937 commented Feb 17, 2020

Two tests of the exact same nature are failing serialization. I am using an Ordereddictionary wrapper that was inspired by something I saw in a stack overflow thread. Pull request #468

Capture

@tgillbe tgillbe mentioned this issue Nov 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good-first-issue This should be easy to pick up if you want to get started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the order of YamlMappingNode items
2 participants
@aaubry @a2937