Skip to content

No interfaces for serializers? #350

Closed
@grofit

Description

@grofit
Contributor

I have a scenario where I want to convert some json to yaml and this looks like the easiest path, but one worrying thing is that there is no interface for Serializer or Deserializer so it is difficult to mock, is there any reason why there is no IYamlSerializer or IYamlDeseralizer or anything which those classes implement so we can then just use that as the contract and mock the Serializer dependencies for unit testing etc?

Activity

aaubry

aaubry commented on Sep 20, 2018

@aaubry
Owner

There's no particular reason for that. If you want to extract the interfaces and submit a pull request, I will publish an updated package immediately.

grofit

grofit commented on Sep 26, 2018

@grofit
ContributorAuthor

Closing this as the merge has added interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @aaubry@grofit

        Issue actions

          No interfaces for serializers? · Issue #350 · aaubry/YamlDotNet