fix: timestamp will work with named machine

[RolandStuder]

This PR makes sure timestamps work also with named machines. Which currently is not the case.

Using timestamps on a named machine like so:

aasm :state, timestamps: true do 

Will result in an error:

AASM::UnknownStateMachineError:
       There is no state machine with the name 'default' defined in TimestampsExample!
     # ./lib/aasm/aasm.rb:70:in `aasm'
     # ./lib/aasm/base.rb:271:in `block in setup_timestamps'

The fix is simple, in ts_setter = "#{aasm(aasm_name).to_state}_at=" it was just missing the aasm_name as an argument. It missing tried to use the default state machine which did not exist.

Tests are updated,to use the timestamps functionality with a named machine. Let me know, if you would prefer for the test to be more explicit about what it checks.

btw: Really love the addition of timestamps, thx to @jaynetics !

[codecov-commenter]

Codecov Report

Merging #739 (23ada79) into master (252ade3) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 23ada79 differs from pull request most recent head ab86f8b. Consider uploading reports for the commit ab86f8b to get more accurate results

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
+ Coverage   95.39%   95.45%   +0.06%     
==========================================
  Files          35       35              
  Lines        1260     1255       -5     
==========================================
- Hits         1202     1198       -4     
+ Misses         58       57       -1     

Impacted Files	Coverage Δ
lib/aasm/base.rb	97.79% <100.00%> (ø)
lib/aasm/core/transition.rb	97.82% <0.00%> (-0.05%)	⬇️
lib/aasm/core/event.rb	97.77% <0.00%> (-0.03%)	⬇️
lib/aasm/core/invoker.rb	100.00% <0.00%> (ø)
lib/aasm/core/invokers/literal_invoker.rb	100.00% <0.00%> (ø)
lib/aasm/persistence/active_record_persistence.rb	92.10% <0.00%> (+1.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252ade3...ab86f8b. Read the comment docs.

[anilmaurya]

Hi @RolandStuder

Thank you for reporting bug and sending PR to fix it.

Instead of updating current test, can you add a separate test for named state machine ?

[codeclimate]

Code Climate has analyzed commit ab86f8b and detected 0 issues on this pull request.

View more on Code Climate.

[RolandStuder]

@anilmaurya updated to use a separate test, I hope this is more or less what you had in mind. (force pushed btw). Thx for the quick response!

[anilmaurya]

Thank you @RolandStuder for contributing 👍