Fixes #709 : Remove memoization to avoid stale localized state name #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A spec verifying bug fix will be good to have. |
the-spectator
force-pushed
the
display_name_709
branch
from
5fdbe1a
to
a59ef08
Compare
the-spectator
force-pushed
the
display_name_709
branch
from
a59ef08
to
e0604ad
Compare
|
Code Climate has analyzed commit 6fcd323 and detected 0 issues on this pull request. View more on Code Climate. |
|
@anilmaurya Added specs. Please have a look at it. |
|
Great @the-spectator , thank you for contributing 🏅 |
|
@anilmaurya will it be alright if this PR to get labeled as |
|
Done @the-spectator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #709
Remove memoization to avoid stale localized state name