Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a state containing valid Sapling and Orchard blocks #8535

Open
upbqdn opened this issue May 14, 2024 · 0 comments
Open

Create a state containing valid Sapling and Orchard blocks #8535

upbqdn opened this issue May 14, 2024 · 0 comments
Labels
A-state Area: State / database changes C-testing Category: These are tests rust Pull requests that update Rust code

Comments

@upbqdn
Copy link
Member

upbqdn commented May 14, 2024

In #8533, we needed a state which contains:

  1. Blocks containing Sapling note commitments.
  2. Blocks for which we could activate NU5, see Create a state containing post-NU5 blocks #8534.
  3. Blocks containing Orchard note commitments.

There's currently no way to create such a state in Zebra. Having it is beneficial for tests, as mentioned below

/// TODO:
/// 1. Check a non-empty Sapling treestate.
/// 2. Check an empty Orchard treestate at NU5 activation height.
/// 3. Check a non-empty Orchard treestate.
///
/// To implement the todos above, we need to:
///
/// 1. Have a block containing Sapling note commitmnets in the state.
/// 2. Activate NU5 at a height for which we have a block in the state.
/// 3. Have a block containing Orchard note commitments in the state.

Depends on #8534.

@upbqdn upbqdn added C-testing Category: These are tests A-state Area: State / database changes rust Pull requests that update Rust code labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-state Area: State / database changes C-testing Category: These are tests rust Pull requests that update Rust code
Projects
Status: New
Development

No branches or pull requests

1 participant